-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost: support for cross-compiling to mips64el #161162
Conversation
Previous push just rebases updates to #161159. |
Latest push rebases against #161159 and squashes this PR into a single commit; no other changes. |
Latest push squashes to a single commit and rebases on #161159; no other changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after that I think we can merge this. Going to build it locally to see if something regresses.
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package marked as broken and skipped:
6 packages failed to build and already failed to build on hydra master:
19 packages failed to build and are new build failures:
38 packages built:
|
Thanks, I am investigating these. |
Resolved merge conflict with |
Okay, latest push should fix the breakage. The patch to backport mips64n64 support doesn't apply cleanly to anything before 1.65, but very few packages require a version of boost older than that. |
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
I'm running |
Of these, only
So, I'm going to say that at this point this PR is not causing any additional breakage. @SuperSandro2000, could you run your bot-tool again? I think this is ready to merge now. |
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 6 packages failed to build and already failed to build on hydra master:
3 packages failed to build and are new build failures:
38 packages built:
|
Yeah these also fail at the commit prior to this PR, so I think nixpkgs-review's list of "existing failures" is slightly out of date or something. |
it uses the latest hydra eval which can be a few days behind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know its already merged, but just wanted to confirm the three failed builds seem to be from before
This patch adds support for cross-compiling boost to a mips64el hostPlatform.
Motivation for this change
This is needed in order to bootstrap nixpkgs on a mips64el hostPlatform -- if the initial mips64el
nix
binary is to be built using nixpkgs, it needs to be cross-compiled from some other platform.Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage